Fix is_formattable for tuple-like types. #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jehelset
force-pushed
the
jehelset/is-tuple-formattable
branch
from
d53bd19
to
0203853
Compare
phprus
reviewed
Jun 18, 2022
vitaut
reviewed
Jun 19, 2022
include/fmt/ranges.h
Outdated
| static decltype(check2( | ||
| index_sequence<I...>{}, | ||
| integer_sequence< | ||
| bool, (fmt::is_formattable<typename std::tuple_element<I, T>::type, |
test/ranges-test.cc
Outdated
Comment on lines
94
to
95
| enum class noformatenum{b}; | ||
| struct noformatstruct{}; |
There was a problem hiding this comment.
Only one unformattable type is needed. Please reuse existing unformattable struct (you might need to move it outside of conditional compilation block).
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2939.
Added a
is_tuple_formattablehelper value-trait to compute the formattability of the element-types of a tuple. Tried to make it look likeis_tuple_likeandis_tuple_like_.Made the
xchar_test.format_mapconditional. This test formats a map, whose value-type isstd::pair<const std::wstring,int>. Because tuple-likes now also take the formattability of element-types into account, and becauseis_formattable<std::wstring>was false locally, this test no longer compiled. I was surprised that something that is not formattable could be formatted in the first place, and chose flight rather than fight.