-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation fails using Clang 17 toolchain #3654
Comments
Removed the nonportable include in 2dd4fa8. Thanks for reporting. |
Note that there is still one include left here: Lines 66 to 68 in 79dbd3f
|
@lazka, could you submit a PR to remove it too? |
2dd4fa8 removed all usage of __std_stream because it is no logner available with clang v17. That missed one place where the header was still used (only used when building with -DFMT_MODULE=ON). Remove it there too. See fmtlib#3654
2dd4fa8 removed all usage of __std_stream because it is no longer available with clang v17. That commit missed one place where the header was still used (only used when building with -DFMT_MODULE=ON). Remove it there too. See fmtlib#3654
sure, #3663 |
@vitaut wouldn't it make more sense to leave this hack for libc++ < 17? (native_handle() should be at 18) |
I don't think it's worth spending any efforts on conditionally supporting this hack for iostreams which are a legacy API. |
2dd4fa8 removed all usage of __std_stream because it is no longer available with clang v17. That commit missed one place where the header was still used (only used when building with -DFMT_MODULE=ON). Remove it there too. See fmtlib#3654
MSYS2 just updated their clang and associated packages to 17.0.1. We are now seeing the following compilation error:
This seems to be related to the following change in libcxx: https://reviews.llvm.org/D147855
The text was updated successfully, but these errors were encountered: