-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect call to fflush() inside write_console() #3688
Comments
dimztimz
added a commit
to dimztimz/fmt
that referenced
this issue
Oct 25, 2023
This change correctly implements https://wg21.link/P2539/ for both C streams and C++ iostreams. Fixes fmtlib#3688.
dimztimz
added a commit
to dimztimz/fmt
that referenced
this issue
Oct 25, 2023
This change correctly implements https://wg21.link/P2539/ for both C streams and C++ iostreams. Fixes fmtlib#3688.
dimztimz
added a commit
to dimztimz/fmt
that referenced
this issue
Oct 25, 2023
This change correctly implements https://wg21.link/P2539/ for both C streams and C++ iostreams. Fixes fmtlib#3688.
dimztimz
added a commit
to dimztimz/fmt
that referenced
this issue
Oct 25, 2023
This change correctly implements https://wg21.link/P2539/ for both C streams and C++ iostreams. Fixes fmtlib#3688.
It is not incorrect, just unnecessary. A PR to remove it would be welcome. |
vitaut
pushed a commit
that referenced
this issue
Oct 25, 2023
This change correctly implements https://wg21.link/P2539/ for both C streams and C++ iostreams. Fixes #3688.
ckerr
pushed a commit
to transmission/fmt
that referenced
this issue
Nov 7, 2023
This change correctly implements https://wg21.link/P2539/ for both C streams and C++ iostreams. Fixes fmtlib#3688.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In this very recent change 3b7f58a which originates from this PR #3668, the added call to
fflush
is incorrect and may brake thestd::ostream
overloads ofprint()
. The intention was to implement the paper https://wg21.link/P2539/ in FMT here.The correct behavior is to remove
fflush
fromwrite_console()
and call it before callingwrite_console()
, but only from the C stream overloads of print, i.e.print(FILE*,...)
. For the ostream overloads one should callostream::flush()
.The text was updated successfully, but these errors were encountered: