-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
join does not use ADL on begin/end of its ranges #3813
Labels
Comments
Not really, just an implementation artefact. A PR to add ADL support is welcome. |
bbolli
added a commit
to bbolli/fmt
that referenced
this issue
Jan 21, 2024
Closes fmtlib#3813 Signed-off-by: Beat Bolli <dev@drbeat.li>
bbolli
added a commit
to bbolli/fmt
that referenced
this issue
Jan 21, 2024
Closes fmtlib#3813 Signed-off-by: Beat Bolli <dev@drbeat.li>
vitaut
pushed a commit
that referenced
this issue
Jan 22, 2024
Closes #3813 Signed-off-by: Beat Bolli <dev@drbeat.li>
happymonkey1
pushed a commit
to happymonkey1/fmt
that referenced
this issue
Apr 7, 2024
Closes fmtlib#3813 Signed-off-by: Beat Bolli <dev@drbeat.li>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
fmt::join
is usingstd::begin
andstd::end
on the range it is being passed. This makes it harder for user-defined types that have their ownbegin
andend
living in their own namespace. E.g., range-for does ADL onbegin
/end
on a range's associated namespaces. It it by design that{fmt}
does not do the same?The text was updated successfully, but these errors were encountered: