Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

join does not use ADL on begin/end of its ranges #3813

Closed
rhalbersma opened this issue Jan 16, 2024 · 1 comment · Fixed by #3824
Closed

join does not use ADL on begin/end of its ranges #3813

rhalbersma opened this issue Jan 16, 2024 · 1 comment · Fixed by #3824
Labels
enhancement help wanted

Comments

@rhalbersma
Copy link

rhalbersma commented Jan 16, 2024 •
edited
Loading

fmt::join is using std::begin and std::end on the range it is being passed. This makes it harder for user-defined types that have their own begin and end living in their own namespace. E.g., range-for does ADL on begin/end on a range's associated namespaces. It it by design that {fmt} does not do the same?
@vitaut
Copy link
Contributor

vitaut commented Jan 16, 2024

It it by design that {fmt} does not do the same?

Not really, just an implementation artefact. A PR to add ADL support is welcome.

bbolli added a commit to bbolli/fmt that referenced this issue Jan 21, 2024
@bbolli
Consider ADL begin() and end() when joining ranges
709be46 
Closes fmtlib#3813

Signed-off-by: Beat Bolli <dev@drbeat.li>
@bbolli bbolli mentioned this issue Jan 21, 2024
Merged
bbolli added a commit to bbolli/fmt that referenced this issue Jan 21, 2024
@bbolli
Consider ADL begin() and end() when joining ranges
48e3ab5 
Closes fmtlib#3813

Signed-off-by: Beat Bolli <dev@drbeat.li>
vitaut pushed a commit that referenced this issue Jan 22, 2024
@bbolli
Consider ADL begin() and end() when joining ranges (#3824)
e1832bc 
Closes #3813

Signed-off-by: Beat Bolli <dev@drbeat.li>
happymonkey1 pushed a commit to happymonkey1/fmt that referenced this issue Apr 7, 2024
@bbolli @happymonkey1
Consider ADL begin() and end() when joining ranges (fmtlib#3824)
d998d8c 
Closes fmtlib#3813

Signed-off-by: Beat Bolli <dev@drbeat.li>
@BrewTestBot BrewTestBot mentioned this issue Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consider ADL begin() and end() when joining ranges bbolli/fmt
2 participants
@vitaut @rhalbersma