Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal supported library subset #418

Closed
alabuzhev opened this issue Nov 9, 2016 · 1 comment
Closed

Minimal supported library subset #418

alabuzhev opened this issue Nov 9, 2016 · 1 comment

Comments

@alabuzhev
Copy link
Contributor

Documentation says that including format.h and format.cc should be enough, but format.cc also includes printf.h and printf.h includes ostream.h.
I've experimented a little, looks like #include "printf.h" in format.cc required only for explicit instantiations of PrintfFormatter for char and wchar_t.
Maybe it's possible to move them to printf.cc?
Do you have any plans to make format.h/cc self-contained?
If no - it's probably worth to update the docs.

@vitaut
Copy link
Contributor

vitaut commented Nov 9, 2016

Good catch, there indeed should be printf.cc and format.cc shouldn't be including printf.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants