iostreams eat exceptions by default, this can lead to incorrect/truncated result

[crusader-mike]

In code snippet below if buffer's overflow() throws an exception (e.g. std::bad_alloc) -- it is going to be silently eaten by output and execution will continue.

// Formats a value.
template <typename Char, typename ArgFormatter_, typename T>
void format_arg(BasicFormatter<Char, ArgFormatter_> &f,
                const Char *&format_str, const T &value) {
  internal::MemoryBuffer<Char, internal::INLINE_BUFFER_SIZE> buffer;

  internal::FormatBuf<Char> format_buf(buffer);
  std::basic_ostream<Char> output(&format_buf);
  output << value;

  BasicStringRef<Char> str(&buffer[0], buffer.size());
  typedef internal::MakeArg< BasicFormatter<Char> > MakeArg;
  format_str = f.format(format_str, MakeArg(str));
}

[vitaut]

Good catch, thanks! Fixed in 2c077dd.

[crusader-mike]

an interesting thought -- what if T's op<< explicitly sets bad/fail bit instead of throwing an exception?

[vitaut]

what if T's op<< explicitly sets bad/fail bit instead of throwing an exception?

¯_(ツ)_/¯. I guess it could be translated into an exception.

[crusader-mike]

Turns out in this case ios_base::failure will be thrown.