Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warnings in msvc2015 around localtime and gmtime #931

Closed
andry81 opened this issue Nov 15, 2018 · 1 comment
Closed

warnings in msvc2015 around localtime and gmtime #931

andry81 opened this issue Nov 15, 2018 · 1 comment

Comments

@andry81
Copy link

andry81 commented Nov 15, 2018

fmt/time.h(51): warning C4996: 'localtime': This function or variable may be unsafe. Consider using localtime_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
fmt/time.h(86): warning C4996: 'gmtime': This function or variable may be unsafe. Consider using gmtime_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.

These warnings goes spammed almost everythere in sources.
DanielaE added a commit to DanielaE/fmt that referenced this issue Nov 25, 2018
@DanielaE
Eliminate msvc compiler warnings (fmtlib#931)
4f8051d 
The sheer presence of 'std::gmtime' or 'std::localtime' gives rise to C4996 warnings in Microsofts compilers. Alas, the 'fallback(internal::null<>)'functions containing these library calls are never ADL-picked in the respective 'handle(internal::null<>)' selectors. Therefore hiding the fallbacks from msvc is perfectly fine.
DanielaE added a commit to DanielaE/fmt that referenced this issue Nov 25, 2018
@DanielaE
Eliminate msvc compiler warnings (fmtlib#931)
a91ff3d 
The sheer presence of 'std::gmtime' or 'std::localtime' gives rise to C4996 warnings in Microsofts compilers. Alas, the 'fallback(internal::null<>)'functions containing these library calls are never ADL-picked in the respective 'handle(internal::null<>)' selectors. Therefore hiding the fallbacks from msvc is perfectly fine.
DanielaE added a commit to DanielaE/fmt that referenced this issue Nov 25, 2018
@DanielaE
Eliminate msvc compiler warnings (fmtlib#931)
f322056 
The sheer presence of 'std::gmtime' or 'std::localtime' gives rise to C4996 warnings in Microsofts compilers. Alas, the 'fallback(internal::null<>)'functions containing these library calls are never ADL-picked in the respective 'handle(internal::null<>)' selectors. Therefore hiding the fallbacks from msvc is perfectly fine.
vitaut pushed a commit that referenced this issue Nov 25, 2018
@DanielaE @vitaut
Eliminate msvc compiler warnings (#931)
fecb2d6 
The sheer presence of 'std::gmtime' or 'std::localtime' gives rise to C4996 warnings in Microsofts compilers. Alas, the 'fallback(internal::null<>)'functions containing these library calls are never ADL-picked in the respective 'handle(internal::null<>)' selectors. Therefore hiding the fallbacks from msvc is perfectly fine.
@vitaut
Copy link
Contributor

vitaut commented Nov 25, 2018

Fixed in fecb2d6.

@vitaut vitaut closed this as completed Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @andry81