Fix compile errors due to name-hiding and an unused function argument. #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Jan 13, 2019
test/prepare-test.cc
Outdated
| @@ -625,7 +625,7 @@ template <typename T> struct user_allocator { | |||
| return new value_type[cnt]; | |||
| } | |||
|
|
|||
| void deallocate(pointer p, size_type cnt) { delete[] p; } | |||
| void deallocate(pointer p, size_type /*cnt*/) { delete[] p; } | |||
There was a problem hiding this comment.
nit: I'd just remove the parameter instead of commenting out.
There was a problem hiding this comment.
Great, wasn't sure about your policy regarding this. This is my preference as well.
These problems are pointed out by clang-tidy and fail compilation on msvc at /W4 /WX. Signed-off-by: Daniela Engert <dani@ngrt.de>
DanielaE
force-pushed
the
fix/compile-errors
branch
from
dc9463e
to
bf23a2c
Compare
|
Done! |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These problems are pointed out by clang-tidy and fail compilation on msvc at /W4 /WX.