Mark deprecated functionality with attributes and remove usage of such features #1022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks features commented as deprecated with attributes;
[[deprecated]]
if compiled with C++14 and__attribute__((deprecated))
or__declspec(deprecated)
if not.I was able to replace most of the cases where deprecated functionality was used in the library, but one case lingers: https://github.com/eliaskosunen/fmt/blob/599632ee226d74d6c34d89290ebabd7320c90afe/include/fmt/format.h#L3061
arg_map::init
takesconst basic_format_args<Context>&
as its sole argument, which can only be extracted fromcontext_base
with the deprecated member functionargs()
.