Fixes for some pedantic warnings #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Feb 23, 2019
| @@ -62,6 +62,10 @@ | |||
| #if FMT_GCC_VERSION >= 406 || FMT_CLANG_VERSION | |||
| # pragma GCC diagnostic push | |||
|
|
|||
| // Disable warning about not handling all enums in switch statement even with | |||
| // a default case | |||
| # pragma GCC diagnostic ignored "-Wswitch-enum" | |||
There was a problem hiding this comment.
Could you post specific warnings this is causing? Might be better to fix those instead of suppressing.
There was a problem hiding this comment.
I thought having a default case is cleaner and just disabling this warning is preferable.
vitaut
reviewed
Feb 23, 2019
|
Thanks for the PR! Just two minor inline comments. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small changes required for me to compile with stricter compiler flags