install pkg-config file into libdir #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most pkgconfig files contain a Libs: variable, which is either /usr/lib or /usr/lib64. If a 32bit and a 64bit variant of fmt libraries is installed, the last one wins. As a result compiling for the other bitsize will fail. Instead of sharedir use libdir as install target. Fixes commit 9d0c9c4 Fixes commit 287342d Signed-off-by: Olaf Hering <olaf@aepfle.de>
|
I've reviewed CONTRIBUTING.md and I agree with the licensing. Thank you! |
|
Thanks for the PR! Is it a standard practice to install |
|
Only if the .pc files references $libdir. For plain data .pc files the /usr/share/pkgconfig should be ok. |
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most pkgconfig files contain a Libs: variable, which is either /usr/lib
or /usr/lib64. If a 32bit and a 64bit variant of fmt libraries is
installed, the last one wins. As a result compiling for the other
bitsize will fail.
Instead of sharedir use libdir as install target.
Fixes commit 9d0c9c4
Fixes commit 287342d
Signed-off-by: Olaf Hering olaf@aepfle.de
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.