Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple of deprecated things. #1102

Closed
wants to merge 1 commit into from
Closed

Fix a couple of deprecated things. #1102

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 31, 2019

Fixes #1101

  • ctx.begin() is deprecated in favor of ctx.out()
  • fmt/time.h is deprecated in favor of fmt/chrono.h
  • The library is compiled with C++11, but auto deduced return types is a C++14 feature. This is only in the docs, but we should be consistent

I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.

@vitaut
Copy link
Contributor

vitaut commented Apr 4, 2019

Merged in b588d7f with minor tweaks (we shouldn't be limited to C++11 in examples, the library has stricter portability requirements than most of the user code). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants