Fix DLL visibility of count_digits<4>(internal::uintptr_t) in format-inl.h
#1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on in format-inl.h In FMT_SHARED mode, format-test.exe wants to DLL import `count_digits<4>(internal::uintptr_t)` explicit full specialization definition in format-inl.h
…on in format-inl.h In FMT_SHARED mode, format-test.exe wants to DLL import `count_digits<4>(internal::uintptr_t)` explicit full specialization definition in format-inl.h
…e `strncpy` Suppress MSVC warnings from `gtest.h` included. Warning sample: fmt-master\test\gtest\gtest.h(2873,10): warning: 'strncpy' is deprecated: This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [-Wdeprecated-declarations]
|
Thanks for the PR. Since |
vitaut
reviewed
May 7, 2019
test/custom-formatter-test.cc
Outdated
| @@ -5,6 +5,12 @@ | |||
| // | |||
| // For the license information refer to format.h. | |||
|
|
|||
| #ifdef _MSC_VER | |||
There was a problem hiding this comment.
Here and below: I'd drop _MSC_VER_ altogether. There is no harm in always defining _CRT_SECURE_NO_WARNINGS.
There was a problem hiding this comment.
Done.
Anyway I notice format-imple-test is exempted when building DLL. When building DLL it includes format-inl.h in which cout_digits resides, I wonder if format-imple-test should be re-enabled also?
…internal::uintptr_t) shall not be exported
…internal::uintptr_t) shall not be exported
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, test-format.exe linking failed because
count_digits<4>(internal::uintptr_t)not found in the DLL.Also suppresses warning of MSVC's
_CRT_INSECURE_DEPRECATEfunctions fromgtest.hincluded in custom-formatter-test.ccI agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.