Fix undefined reference & and one warning #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QtCreator (4.9) Clang Code Model (Clang 7) gives the warning:core.h:404:11: error: an attribute list cannot appear here core.h:116:24: note: expanded from macro 'FMT_NORETURN'
Reenabling Compiling and Linking as DLL.
HazardyKnusperkeks
force-pushed
the
master
branch
2 times, most recently
from
6c3f86c
to
0aa7b73
Compare
vitaut
requested changes
Jun 24, 2019
| @@ -417,7 +417,7 @@ typedef basic_memory_buffer<char> memory_buffer; | |||
| typedef basic_memory_buffer<wchar_t> wmemory_buffer; | |||
|
|
|||
| /** A formatting error such as invalid format string. */ | |||
| class format_error : public std::runtime_error { | |||
| class FMT_API format_error : public std::runtime_error { | |||
There was a problem hiding this comment.
Only the destructor needs to be marked with FMT_API.
There was a problem hiding this comment.
That was my first pull request, but then I got undefined reference to the vtable, which is not exported in that case. If you know how to export the vtable explicitly I will change it.
| @@ -2198,7 +2198,7 @@ class arg_formatter : public internal::arg_formatter_base<Range> { | |||
| An error returned by an operating system or a language runtime, | |||
| for example a file opening error. | |||
| */ | |||
| class system_error : public std::runtime_error { | |||
| class FMT_API system_error : public std::runtime_error { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.
Fixes #1205