Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decay argument types in call to do_check_format_string #1293

Closed
wants to merge 1 commit into from

Conversation

marack
Copy link

@marack marack commented Aug 30, 2019

I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.

This change fixes issue #1292 which causes the UDL template based formatter to fail when passed and lvalue to a user defined type despite an appropriate custom formatter being available.

@vitaut
Copy link
Contributor

vitaut commented Aug 31, 2019

Thanks for the PR. std::decay is a bit too strong, so I used remove_cvref_t instead and added a regression test in 422e7b9.

@vitaut vitaut closed this Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants