Fix Visual Studio 2019 pedantic warning C4334: '<<': result of 32-bit… #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… shift implicitly converted to 64 bits (was 64-bit shift intended?)
vitaut
requested changes
Oct 14, 2019
| @@ -981,7 +981,7 @@ FMT_FUNC void fallback_format(Double v, buffer<char>& buf, int& exp10) { | |||
| denominator <<= 1 - fp_value.e; | |||
| lower.assign(1); | |||
| if (shift != 0) { | |||
| upper_store.assign(1 << shift); | |||
| upper_store.assign(1ull << shift); | |||
There was a problem hiding this comment.
The result must be 32-bit. Does changing 1 to 1u works around the bogus warning?
There was a problem hiding this comment.
Unfortunately no, faliled with the similar warning:
format-inl.h(984,1): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
There was a problem hiding this comment.
Maybe this fix will be suitable?
upper_store.assign((1ull << shift) & 0xFFFFFFFF);
|
Thinking more of it, the type doesn't really matter because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.