Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build under g++-4.9, SunOS 5.11 i386 i86pc Solaris #138

Merged
merged 1 commit into from
Mar 18, 2015
Merged

Fix build under g++-4.9, SunOS 5.11 i386 i86pc Solaris #138

merged 1 commit into from
Mar 18, 2015

Conversation

Naios
Copy link
Contributor

@Naios Naios commented Mar 18, 2015

Fixes a build error on SunOS 5.11 caused through a duplicated variable name (probably in system headers).

Naios referenced this pull request in TrinityCore/TrinityCore Mar 18, 2015
Type safe logging
(cherry picked from commit cc0c9ad)

Conflicts:
	src/server/bnetserver/CMakeLists.txt
	src/server/game/Server/WorldSocketMgr.cpp
	src/server/shared/Logging/AppenderDB.cpp
	src/server/worldserver/CMakeLists.txt
vitaut added a commit that referenced this pull request Mar 18, 2015
Fix build under g++-4.9, SunOS 5.11 i386 i86pc Solaris
@vitaut vitaut merged commit 23b60f5 into fmtlib:master Mar 18, 2015
@vitaut
Copy link
Contributor

vitaut commented Mar 18, 2015

Merged, thanks.

For future reference, here's the error (copied from http://pastebin.com/JkxfgLZD):

/mnt/software/solaris/wow/TrinityCore_3_3_5a/build# make
In file included from /usr/include/sys/ucontext.h:36:0,
                 from /usr/include/sys/signal.h:245,
                 from /usr/include/sys/procset.h:42,
                 from /usr/include/sys/wait.h:43,
                 from /usr/include/stdlib.h:38,
                 from /opt/csw/include/c++/4.9.2/cstdlib:72,
                 from /opt/csw/include/c++/4.9.2/bits/stl_algo.h:59,
                 from /opt/csw/include/c++/4.9.2/algorithm:62,
                 from /mnt/software/solaris/wow/TrinityCore_3_3_5a/dep/cppformat/format.h:37,
                 from /mnt/software/solaris/wow/TrinityCore_3_3_5a/dep/cppformat/format.cc:28:
/mnt/software/solaris/wow/TrinityCore_3_3_5a/dep/cppformat/format.cc: In function ‘void {anonymous}::format_error_code(fmt::Writer&, int, fmt::StringRef)’:
/mnt/software/solaris/wow/TrinityCore_3_3_5a/dep/cppformat/format.cc:182:21: error: expected unqualified-id before numeric constant
   static const char ERR[] = "error ";
                     ^
compilation terminated due to -Wfatal-errors.
make[2]: *** [dep/cppformat/CMakeFiles/format.dir/format.cc.o] Error 1
make[1]: *** [dep/cppformat/CMakeFiles/format.dir/all] Error 2
make: *** [all] Error 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants