clang-tidy fixes #1397
Merged
clang-tidy fixes #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found with modernize-use-equals-delete Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with hicpp-uppercase-literal-suffix Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with modernize-return-braced-init-list Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with bugprone-macro-parentheses Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with performance-noexcept-move-constructor Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with hicpp-use-auto Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with hicpp-use-equals-default Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with hicpp-use-override Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with modernize-deprecated-headers Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out clang-tidy doesn't check the headers by default.