Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix -Wconversion warnings #1427

Merged
merged 2 commits into from
Nov 28, 2019
Merged

Fix -Wconversion warnings #1427

merged 2 commits into from
Nov 28, 2019

Conversation

0x8000-0000
Copy link
Contributor

I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.

@0x8000-0000
Copy link
Contributor Author

This would close #1422

vitaut
vitaut requested changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

include/fmt/format.h Outdated Show resolved Hide resolved
include/fmt/posix.h Outdated Show resolved Hide resolved
@0x8000-0000
Fix -Wconversion warnings
0067987
@0x8000-0000
Remove invalid noexcept annotation
05a2dcc 
buffered_file& operator=(buffered_file&& other) calls close which can
throw.
@vitaut vitaut merged commit ea54b21 into fmtlib:master Nov 28, 2019
@vitaut
Copy link
Contributor

vitaut commented Nov 28, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaut vitaut Awaiting requested review from vitaut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x8000-0000 @vitaut