Avoid possible namespace clash for fmt #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem In the case of an existing `fmt` namespace (in my project this looks like `Project::fmt`) it is possible to get a namespace clash in debug builds (MSVC 2017) ## Proposed Solution When referencing `fmt` internally, be explicit that it is relative to the global namespace using `::fmt`
lefticus
added a commit
to NREL/EnergyPlus
that referenced
this pull request
Jan 15, 2020
@mjwitte I believe this is the correct solution instead of chasing down potential conflicts over and over. I've submitted a patch to {fmt} fmtlib/fmt#1522
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the case of an existing
fmtnamespace (in my project this looks likeProject::fmt) it is possible to get a namespace clash in debug builds (MSVC 2017)Proposed Solution
When referencing
fmtinternally, be explicit that it is relative to the global namespace using::fmtI agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.