Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for building with MinGW on Windows #1532

Closed
wants to merge 1 commit into from
Closed

Workaround for building with MinGW on Windows #1532

wants to merge 1 commit into from

Conversation

sakiryu
Copy link

@sakiryu sakiryu commented Jan 22, 2020 •
edited
Loading

"Solves" #1531

G++ Version: 8.2.0

@sakiryu sakiryu requested a review from vitaut January 22, 2020 19:42
@vitaut
Copy link
Contributor

vitaut commented Jan 22, 2020

Thanks! LGTM but I'd suggest changing "segfault" to "internal compiler error" in the commit message for clarity.

@vitaut
Copy link
Contributor

vitaut commented Jan 23, 2020

Merged with minor tweaks in 9fc4161.

@vitaut vitaut closed this Jan 23, 2020
@tt4g tt4g mentioned this pull request Apr 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaut vitaut Awaiting requested review from vitaut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakiryu @vitaut