Fix FMT_FORMAT_AS const specifier position #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current `FMT_FORMAT_AS` macro will make `formatter<Char *>::format` have the first argument type `const Char *&` which is incorrect an should be `Char *const &`. This pull request fixes that by changing the first argument type in the macro definition body from `const Type &` to `Type const &`.
|
Good catch, thanks! |
sthagen
added a commit
to sthagen/fmtlib-fmt
that referenced
this pull request
Feb 23, 2020
Fix FMT_FORMAT_AS const specifier position (fmtlib#1554)
teajay-fr
pushed a commit
to teajay-fr/fmt
that referenced
this pull request
Mar 18, 2020
The current `FMT_FORMAT_AS` macro will make `formatter<Char *>::format` have the first argument type `const Char *&` which is incorrect an should be `Char *const &`. This pull request fixes that by changing the first argument type in the macro definition body from `const Type &` to `Type const &`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
FMT_FORMAT_ASmacro will makeformatter<Char *>::formathave the first argument type
const Char *&which is incorrect anshould be
Char *const &. This pull request fixes that by changing thefirst argument type in the macro definition body from
const Type &toType const &.I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.