Fix clang -Wdisabled-macro-expansion warning from FMT_STRING_IMPL. #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Mar 4, 2020
include/fmt/format.h
Outdated
| @@ -3504,15 +3504,15 @@ FMT_END_NAMESPACE | |||
| #define FMT_STRING_IMPL(s, ...) \ | |||
| [] { \ | |||
| /* Use a macro-like name to avoid shadowing warnings. */ \ | |||
| struct FMT_STRING : fmt::compile_string { \ | |||
| struct INVOKE_FMT_STRING : fmt::compile_string { \ | |||
There was a problem hiding this comment.
I suggest renaming to FMT_COMPILE_STRING to follow the naming convention for {fmt} macros as per comment above.
There was a problem hiding this comment.
Updated to use FMT_COMPILE_STRING as suggested.
FMT_STRING_IMPL has an internal helper named FMT_STRING, however FMT_STRING is also the name of the macro that invokes FMT_STRING_IMPL. Renaming this helper avoids the appearance of a recursive macro.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FMT_STRING_IMPL has an internal helper named FMT_STRING, however FMT_STRING is also the name of the macro that invokes FMT_STRING_IMPL.
Renaming this helper avoids the appearance of a recursive macro.