Color formatting fixed for wide strings (fixes issue #1594) #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Mar 16, 2020
Comment on lines
+53
to
+54
| EXPECT_EQ(fmt::format(fg(fmt::rgb(255, 20, 30)), L"rgb(255,20,30) wide"), | ||
| L"\x1b[38;2;255;020;030mrgb(255,20,30) wide\x1b[0m"); |
There was a problem hiding this comment.
I think one test case for wide strings is enough since the code paths are shared - it either all works or all doesn't. Let's remove all the ones below.
There was a problem hiding this comment.
Alright, should be done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.
Along with the fix I added tests that mirror their non-wide counterparts. I did NOT add tests for file writing (EXPECT_WRITE) as there doesn't seem to be an implementation using wide strings in the gtest-extra code. This is something I don't really know how to tackle, so I'd leave it up to somebody else to do.