Make dynamic_format_arg_store reusable and add reserve() #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reserve() for better memory menagement.
vsolontsov-ll
changed the title
vitaut
reviewed
May 12, 2020
include/fmt/core.h
Outdated
| */ | ||
| void reserve(size_t new_cap, size_t new_cap_named) { | ||
| FMT_ASSERT(new_cap >= new_cap_named, | ||
| "Set of argument includes set of named arguments"); |
There was a problem hiding this comment.
done. thanks for the review.
|
One nit, otherwise LGTM. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #1674.
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.