Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested replacement fields may omit arg_id #1681

Merged
merged 1 commit into from
May 14, 2020
Merged

Conversation

puetzk
Copy link
Contributor

@puetzk puetzk commented May 13, 2020

syntax.html already has examples like fmt::format("{:.{}f}", 3.14, 1) using this,
and https://en.cppreference.com/w/cpp/utility/format/formatter#width_and_precision shows that this is the case for the C++20 std::format

The Format Specification Mini-Language grammar seems to be the only one not showing this; update it to match.

I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.

Closes fmtlib/fmt.dev#10

syntax.html already has examples like `fmt::format("{:.{}f}", 3.14, 1)` using this, 
and https://en.cppreference.com/w/cpp/utility/format/formatter#width_and_precision shows that this is the case for the C++20 std::format

The Format Specification Mini-Language grammar seems to be the only one not showing this; update it to match.
@vitaut vitaut merged commit 981b517 into fmtlib:master May 14, 2020
@vitaut
Copy link
Contributor

vitaut commented May 14, 2020

Good catch, thanks!

@puetzk puetzk deleted the patch-1 branch May 14, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants