make plus flag for printf not be ignored for char argument #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
addresses #1682 |
rimathia
commented
May 14, 2020
include/fmt/printf.h
Outdated
| @@ -257,7 +257,7 @@ class printf_arg_formatter : public detail::arg_formatter_base<Range> { | |||
| return (*this)(static_cast<int>(value)); | |||
| fmt_specs.sign = sign::none; | |||
| fmt_specs.alt = false; | |||
| fmt_specs.align = align::right; | |||
| if (fmt_specs.align == align::numeric) fmt_specs.align = align::right; | |||
There was a problem hiding this comment.
I'm not sure which possible values of align really have to be overwritten here. align::numeric is the one case where a test fails if it isn't overwritten.
There was a problem hiding this comment.
I think this should be align::none, not align::numeric, because none is the default and here we are trying to change the default to right alignment.
|
Thanks for the PR! |
rimathia
commented
May 15, 2020
| @@ -257,7 +257,10 @@ class printf_arg_formatter : public detail::arg_formatter_base<Range> { | |||
| return (*this)(static_cast<int>(value)); | |||
| fmt_specs.sign = sign::none; | |||
| fmt_specs.alt = false; | |||
| fmt_specs.align = align::right; | |||
| // align::numeric needs to be overwritten here since the '0' flag is | |||
| // ignored for non-numeric types | |||
There was a problem hiding this comment.
The test which is affected from not overwriting align::numeric here is EXPECT_PRINTF("0000x", "%05c", 'x').
|
Thanks! |
|
Thanks to you for getting to it so quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.