Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Cmake to find Python and Sphinx-doc #1760

Closed
wants to merge 1 commit into from
Closed

Use Cmake to find Python and Sphinx-doc #1760

wants to merge 1 commit into from

Conversation

xvitaly
Copy link
Contributor

@xvitaly xvitaly commented Jul 7, 2020

Use Cmake to find Python and Sphinx-doc.

I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.

vitaut
vitaut requested changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good just minor comments inline.

doc/CMakeLists.txt Outdated Show resolved Hide resolved
doc/CMakeLists.txt Outdated Show resolved Hide resolved
@xvitaly
Use Cmake to find Python and Sphinx-doc.
028bb05 
Signed-off-by: Vitaly Zaitsev <vitaly@easycoding.org>
@xvitaly
Copy link
Contributor Author

xvitaly commented Jul 8, 2020

Done.

@vitaut
Copy link
Contributor

vitaut commented Jul 8, 2020

Merged in 638db5c, thanks!

@vitaut vitaut closed this Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaut vitaut vitaut requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xvitaly @vitaut