Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add format_to_n overload that accepts FMT_COMPILE #1767

Closed
wants to merge 1 commit into from
Closed

Add format_to_n overload that accepts FMT_COMPILE #1767

wants to merge 1 commit into from

Conversation

Kurkin
Copy link
Contributor

@Kurkin Kurkin commented Jul 11, 2020

Resolves #1764

I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.

vitaut
vitaut requested changes Jul 12, 2020
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

include/fmt/compile.h Outdated Show resolved Hide resolved
@Kurkin Kurkin requested a review from vitaut July 12, 2020 13:35
@vitaut
Copy link
Contributor

vitaut commented Jul 12, 2020

Looks good but could you also add a unit test similar to

fmt/test/compile-test.cc

Line 156 in bd903f9

TEST(CompileTest, FormatTo) {

@vitaut
Copy link
Contributor

vitaut commented Aug 26, 2020

Closing due to inactivity but feel free to resubmit with a test.

@vitaut vitaut closed this Aug 26, 2020
@alexezeder alexezeder mentioned this pull request Sep 14, 2020
Merged
vitaut pushed a commit that referenced this pull request Sep 15, 2020
@alexezeder @Kurkin
Add format_to_n overload that accepts FMT_COMPILE (from #1767) (#1869)
f674434 
* Add format_to_n overload that accepts FMT_COMPILE

* add FormatToNWithCompileMacro test into CompileTest

Co-authored-by: Dmitriy Kurkin <Dmitriy.Kurkin@itiviti.com>
@vitaut vitaut mentioned this pull request Sep 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaut vitaut Awaiting requested review from vitaut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fmt::format_to_n does not work with FMT_COMPILE-d format string
2 participants
@Kurkin @vitaut