Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tested CMake version to 3.18 #1783

Merged
merged 1 commit into from
Jul 19, 2020
Merged

Bump tested CMake version to 3.18 #1783

merged 1 commit into from
Jul 19, 2020

Conversation

tambry
Copy link
Contributor

@tambry tambry commented Jul 18, 2020

Use the version range feature introduced in 3.12. On CMake <3.12 the extra dots are simply interpreted as extra version number separators.
The fallback for ancient CMake versions is kept.

I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.

Use the version range feature introduced in 3.12. On CMake <3.12 the extra dots are simply interpreted as extra version number separators.
The fallback for ancient CMake versions is kept.
@vitaut
Copy link
Contributor

vitaut commented Jul 19, 2020

Thanks for the PR. Is there any benefit to using a version range?

@tambry
Copy link
Contributor Author

tambry commented Jul 19, 2020

Thanks for the PR. Is there any benefit to using a version range?

Compared to the current approach of an if it's simpler.

Otherwise, using a range enables policies for versions up to the max version (usually the latest tested version).
So with cmake_minimum_required(VERSION 3.1...3.18) CMake 3.1 is the minimum version required. Using CMake 3.14 you get the NEW policies up to version 3.14. Using CMake 3.20 you'd get policies up to version 3.18.

@vitaut vitaut merged commit 26b47b6 into fmtlib:master Jul 19, 2020
@tambry tambry deleted the cmake_range branch July 20, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants