Fix detail::write with fallback formatter #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to check fmt::to_string() with class that has output stream operator
to check fmt::format() with FMT_COMPILE() and class that has output stream operator
vitaut
requested changes
Aug 19, 2020
vitaut
reviewed
Aug 19, 2020
|
Thank you! |
facebook-github-bot
pushed a commit
to facebookarchive/profilo
that referenced
this pull request
Aug 28, 2020
Summary: Backport fmtlib/fmt#1829 to make sure that `fmt::to_string` supports streamable types. Reviewed By: h-friederich Differential Revision: D23387021 fbshipit-source-id: f538525a6fe2a296b508164f19a8bc0704183666
EduardoCostaom
pushed a commit
to EduardoCostaom/profilo
that referenced
this pull request
Nov 2, 2022
Summary: Backport fmtlib/fmt#1829 to make sure that `fmt::to_string` supports streamable types. Reviewed By: h-friederich Differential Revision: D23387021 fbshipit-source-id: f538525a6fe2a296b508164f19a8bc0704183666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I was trying to use both
FMT_COMPILE()and struct with ostream operator, but with no luck. After first look on issues and pull requests I found one issue that describes the same problem, here it is - #1815.I'm not sure that this solution is clean enough, but I am open to change whatever you want.
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.