Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mingw32/mingw64 build #1860

Merged
merged 2 commits into from
Sep 6, 2020
Merged

Fixed mingw32/mingw64 build #1860

merged 2 commits into from
Sep 6, 2020

Conversation

chronoxor
Copy link
Contributor

Fixed mingw32/mingw64 build

In file included from C:\projects\gil\sample\CppLogging\modules\CppCommon\modules\fmt\src\format.cc:8:
C:/projects/gil/sample/CppLogging/modules/CppCommon/modules/fmt/include/fmt/format-inl.h:29: error: "NOMINMAX" redefined [-Werror]
 #    define NOMINMAX
 
In file included from C:/mingw64/lib/gcc/x86_64-w64-mingw32/8.1.0/include/c++/x86_64-w64-mingw32/bits/c++config.h:508,
                 from C:/mingw64/lib/gcc/x86_64-w64-mingw32/8.1.0/include/c++/cassert:43,
                 from C:/projects/gil/sample/CppLogging/modules/CppCommon/modules/fmt/include/fmt/format-inl.h:11,
                 from C:\projects\gil\sample\CppLogging\modules\CppCommon\modules\fmt\src\format.cc:8:
C:/mingw64/lib/gcc/x86_64-w64-mingw32/8.1.0/include/c++/x86_64-w64-mingw32/bits/os_defines.h:45: note: this is the location of the previous definition
 #define NOMINMAX 1

I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.

Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

include/fmt/format-inl.h Outdated Show resolved Hide resolved
@vitaut vitaut merged commit f19b888 into fmtlib:master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants