Disable fallthrough attributes for the Intel compilers on Linux and MacOS #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On MacOS and Linux the Intel compilers may be identified as the host compilers (Clang or GNU) but do not support the corresponding compiler specific fallthrough attributes.
vitaut
requested changes
Sep 18, 2020
include/fmt/format.h
Outdated
| @@ -70,9 +70,9 @@ | |||
| #endif | |||
|
|
|||
| #if __cplusplus == 201103L || __cplusplus == 201402L | |||
| # if defined(__clang__) | |||
| # if defined(__clang__) && !defined(__INTEL_COMPILER) | |||
There was a problem hiding this comment.
I suggest moving the Intel compiler check in a branch of its own, something like
# ifdef __INTEL_COMPILER
# define FMT_FALLTHROUGH
# elif ...to avoid repetition.
There was a problem hiding this comment.
how about something like this? looks like PGI falls into the same category.
This puts Intel and PGI compilers into a separate group and thus makes the intent and logic more obvious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacOS and Linux the Intel compilers may be identified as the host compilers (Clang or GNU) but do not support the corresponding compiler specific fallthrough attributes. This pull request adds conditions to the preprocessor tests to skip using those in those cases.
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.