Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added position independent documentation #1939

Merged
merged 3 commits into from
Oct 19, 2020
Merged

added position independent documentation #1939

merged 3 commits into from
Oct 19, 2020

Conversation

udnaan
Copy link
Contributor

@udnaan udnaan commented Oct 17, 2020

Just a documentation update since not everyone who may come across this library would be familiar with all the CMAKE variables.

vitaut
vitaut requested changes Oct 17, 2020
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good but please address minor comments and break long line (we use 80 character limit when possible).

doc/usage.rst Outdated Show resolved Hide resolved
vitaut
vitaut requested changes Oct 19, 2020
View reviewed changes
doc/usage.rst Outdated Show resolved Hide resolved
@vitaut vitaut merged commit 17fba75 into fmtlib:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaut vitaut vitaut requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@udnaan @vitaut