Support compiling {fmt} as named module #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielaE
force-pushed
the
feature/named-module
branch
2 times, most recently
from
8bc95b8
to
1948ae5
Compare
vitaut
reviewed
Apr 16, 2021
include/fmt/color.h
Outdated
| @@ -231,6 +235,7 @@ struct color_type { | |||
| } // namespace detail | |||
|
|
|||
| /** A text style consisting of foreground and background colors and emphasis. */ | |||
| FMT_MODULE_EXPORT | |||
There was a problem hiding this comment.
Why not include this class in the FMT_MODULE_EXPORT_BEGIN/FMT_MODULE_EXPORT_END block below and remove FMT_MODULE_EXPORT?
There was a problem hiding this comment.
Yes, why not? I'll tell ya: staring at code for extended periods of time didn't prevent me from being silly.
include/fmt/printf.h
Outdated
| template <typename Char> | ||
| class basic_printf_parse_context : public basic_format_parse_context<Char> { | ||
| using basic_format_parse_context<Char>::basic_format_parse_context; | ||
| }; | ||
| // already exported through "ostream.h" above |
There was a problem hiding this comment.
Let's remove this comment, the one above can apply to both contexts.
* functions * classes * UDLs * other declarations Export everything in namespace 'fmt' from core.h and format.h
DanielaE
force-pushed
the
feature/named-module
branch
from
1948ae5
to
16a4cc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start by tagging official API for module export