Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSVC warning C4819 #2395

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Fix MSVC warning C4819 #2395

merged 1 commit into from
Jun 28, 2021

Conversation

erengy
Copy link
Contributor

@erengy erengy commented Jun 27, 2021

Hi,

I'm using Visual Studio 2019 Version 16.10.2 on Windows with Japanese system locale (code page 932).

Upgrading from fmt 7.1.3 to 8.0.0 resulted in Compiler Warning (level 1) C4819:

warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss

The issue was introduced in 7e72673.

@vitaut vitaut merged commit c3c27e5 into fmtlib:master Jun 28, 2021
@vitaut
Copy link
Contributor

vitaut commented Jun 28, 2021

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants