Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace throw with FMT_THROW #2427

Merged
merged 1 commit into from
Jul 18, 2021
Merged

Replace throw with FMT_THROW #2427

merged 1 commit into from
Jul 18, 2021

Conversation

TrebledJ
Copy link
Contributor

Using throw results in compile errors with -fno-exceptions. gcc seems fine with throw, but arm-gcc and clang would complain.

Using `throw` results in compile errors with `-fno-exceptions`. gcc seems fine with it, but arm-gcc and clang would complain.
@vitaut vitaut merged commit f20f503 into fmtlib:master Jul 18, 2021
@vitaut
Copy link
Contributor

vitaut commented Jul 18, 2021

Thank you!

sthagen added a commit to sthagen/fmtlib-fmt that referenced this pull request Jul 18, 2021
Replace `throw` with `FMT_THROW` (fmtlib#2427)
PoetaKodu pushed a commit to pacc-repo/fmt that referenced this pull request Nov 11, 2021
Using `throw` results in compile errors with `-fno-exceptions`. gcc seems fine with it, but arm-gcc and clang would complain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants