Simplifying format_decimal() #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Sep 12, 2021
include/fmt/format.h
Outdated
Comment on lines
1078
to
1079
| char dc0 = *src++; | ||
| char dc1 = *src; |
There was a problem hiding this comment.
No need to introduce these variables.
There was a problem hiding this comment.
All the same, this gives the compiler the ability to generate more efficient code. (Although he may not use it)
There was a problem hiding this comment.
Could you give an example on godbolt illustrating this?
There was a problem hiding this comment.
https://godbolt.org/z/YKvoshP8K This is not enough? We untie the compiler's hands without losing anything.
There was a problem hiding this comment.
Interesting. Could you add a short comment clarifying that this opens optimization opportunities because otherwise it might be tempting to remove these seemingly redundant variables?
Roman-Koshelev
force-pushed
the
master
branch
from
f45b908
to
4d79384
Compare
Roman-Koshelev
force-pushed
the
master
branch
from
4d79384
to
9052207
Compare
vitaut
approved these changes
Sep 12, 2021
|
Thank you! |
PoetaKodu
pushed a commit
to pacc-repo/fmt
that referenced
this pull request
Nov 11, 2021
* Add copy2() constexpr * Removed redundant format_decimal implementation for constexpr context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.