Upgrade module-test to msvc 16.11.5 and 17.0-pre5
#2558
Conversation
| ((_MSC_VER == 1929 && _MSC_FULL_VER <= 192930136) || \ | ||
| (_MSC_VER == 1930 && _MSC_FULL_VER <= 193030704)) |
There was a problem hiding this comment.
Why check both _MSC_VER and _MSC_FULL_VER? Also wouldn't it be enough to replace all four checks with _MSC_FULL_VER <= 193030704?
There was a problem hiding this comment.
That's simple: _MSC_VER == 1929 is VS2019, while 1930 is VS2020. All of them are ABI-compatible, therefore they share the 19 - it's basically ABI 19.
So the check is for 'up to VS2019 Update 11 Fix 5' (a.k.a. msvc 16.11.5) in the VS2019 series and 'up to VS2022 Preview 5' (a.k.a. msvc 17.0-pre5) in the VS2022 series. The gap between the both is for an upcoming (final?) compiler version in the VS2019 series that is supposed to wrap-up VS2019 with some feature/fix backports from VS2022. This one might eventally fix this the non-exported namespace issue.
@cdacamar Cameron: or is this completely out of the picture? In this case we could totally forget about VS2019 from here on.
Addresses issue #2557