Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix throw with exceptions disabled #2647

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Fix throw with exceptions disabled #2647

merged 1 commit into from
Dec 17, 2021

Conversation

alexezeder
Copy link
Contributor

@alexezeder alexezeder commented Dec 13, 2021 •
edited
Loading

Originated from 215f21a#r61421336.

throw replaced with FMT_THROW, nothing more.

But the most interesting part here is why it was not detected by tests - it's described in #2648.

@alexezeder alexezeder mentioned this pull request Dec 13, 2021
Merged
@vitaut vitaut merged commit 82246b8 into fmtlib:master Dec 17, 2021
@vitaut
Copy link
Contributor

vitaut commented Dec 17, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexezeder @vitaut