Enable named arguments check in compile-time checks #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
works only if all named arguments are UDL-based
vitaut
reviewed
Dec 17, 2021
Comment on lines
+3051
to
+3052
| if constexpr (detail::count_named_args<Args...>() == | ||
| detail::count_statically_named_args<Args...>()) { |
There was a problem hiding this comment.
Doesn't this effectively make fmt::arg unusable?
There was a problem hiding this comment.
As far as I understand, fmt::arg is handled the same way as before. Consider the following table with results of boolean expressions inside this if:
master |
PR | |
|---|---|---|
| w/o named arguments | true | true |
fmt::arg |
false | false |
_a |
false | true |
fmt::arg + _a |
false | false |
This way, nothing should change for fmt::arg. In contrast with format string with a mix of named and non-named arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originated from #2640.
This check works only if all named arguments are UDL-based (
statically_named).Also, I'm not sure about format strings like
"{} {named1}{named2}", they work inmaster, but by enabling this check I also applied the same logic for them asFMT_STRINGandFMT_COMPILEhave. So, those format string do not work.It would be nice to add some compile-time error checks for this check in this PR, but it's probably should be done in #2648.