Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix throw with exceptions disabled and improve noexception test #2677

Merged
merged 2 commits into from
Dec 27, 2021

Conversation

phprus
Copy link
Contributor

@phprus phprus commented Dec 26, 2021

throw replaced with FMT_THROW in chrono.h.
Improve noexception test.

@alexezeder
Copy link
Contributor

We can probably change noexception-test to include all headers. This way, it would also fail for commits like eab2ea9.

@phprus phprus changed the title Fix throw with exceptions disabled Fix throw with exceptions disabled and improve noexception test Dec 26, 2021
@alexezeder
Copy link
Contributor

It looks like GCC doesn't care about throw in headers with exceptions disabled with no usage in cpp file. But at least Clang cares.

@vitaut vitaut merged commit 33ee4cc into fmtlib:master Dec 27, 2021
@vitaut
Copy link
Contributor

vitaut commented Dec 27, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants