Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecvt warning (#2408) #2725

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Fix codecvt warning (#2408) #2725

merged 1 commit into from
Jan 19, 2022

Conversation

ivan-volnov
Copy link
Contributor

No description provided.

@JoeLoser
Copy link

JoeLoser commented Jan 19, 2022

LGTM! I verified in my codebase this workaround is sufficient when using clang13 and libc++ in C++23 mode (C++20 or later is fine to trigger the issue) as reported. Thanks for the fix!

@vitaut vitaut merged commit cdf1a3b into fmtlib:master Jan 19, 2022
@vitaut
Copy link
Contributor

vitaut commented Jan 19, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants