Making target_compile_options PRIVATE, fix #2726, fix #2507 #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Jan 22, 2022
Comment on lines
253
to
255
| if (${FMT_HAS_MBIG_OBJ}) | ||
| target_compile_options(fmt PUBLIC "-Wa,-mbig-obj") | ||
| target_compile_options(fmt PRIVATE "-Wa,-mbig-obj") | ||
| endif() |
There was a problem hiding this comment.
I suggest removing this block altogether because this is some old workaround that may not even be applicable any more. We can always reintroduce the workaround as an opt-in if it happens again.
There was a problem hiding this comment.
The issue #1684 is less than 2 years old...
There was a problem hiding this comment.
Yeah, but it's unclear what purpose -Wa,-mbig-obj serves here. The library itself is very small and unlikely to cause linker issues so it might be solving a problem elsewhere.
There was a problem hiding this comment.
BTW this option was added in #1716. Maybe @ambitslix can shed light why it was needed.
vitaut
approved these changes
Jan 23, 2022
|
Anyway, let's merge this as an immediate fix for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I weren't able to reach @ambitslix in the issue #1684 so I am not sure what exactly caused the problem for him. I think that making compile options private is a good compromise. It is always easier to add an option to the project using the library than removing an option set by an included library and unconditionally propagated to the whole project using it. This should close #2726 and also solve an already closed #2507. Probably this target_compile_options can be removed completely, I don't think there was an issue building the library itself, but I don't have an environment to reproduce the error that this line solved on the first place.