Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc warnings #2801

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Misc warnings #2801

merged 2 commits into from
Mar 24, 2022

Commits on Mar 24, 2022

  1. Fixed all clang -Wreserved-id-macro warnings (on macOS at least) 

    Avoid defining various reserved identifiers (starting with underscore and capital letter).  Fortunately, they were all Windows-only, so it was easy to conditionalize them in Window-only preprocessor checks.
    @seanm
    seanm committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    c6d7691 View commit details
    Browse the repository at this point in the history

  2. Fixed clang -Wreserved-identifier warings 

    Created FMT_UNCHECKED_TYPE that resolves to special identifier _Unchecked_type for Microsoft, but to a dummy string otherwise. Using
_Unchecked_type is invalid because underscore + uppercase is a reserved identifier.
    @seanm
    seanm committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    098b9d2 View commit details
    Browse the repository at this point in the history