Fixed all clang -Wsigned-enum-bitfield warnings #2833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made enums involved in bitfields unsigned. Used unsigned char specifically because gcc before 9.3 seems to have a bug where it warns about bitfields not being big enough to hold the enum, even though they are.
|
So I'm just headed on vacation, but when back I'll take another stab at making the old gcc happy... |
|
Closing for now to reduce noise but feel free to reopen once it's ready for review. |
|
@vitaut I don't think I have permission to reopen this issue, but I have an updated commit. Can you reopen this please? |
|
Unfortunately I cannot reopen it either because the branch was force-pushed so you'll have to create a new PR. |
|
I pushed my updated commit, which I thought would automatically reopen this PR, but I guess that's not how github works? Must one first reopen a PR before updating it? Anyway, new PR coming... |
I think so. GitHub is weird in this respect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made enums involved in bitfields unsigned.
Used unsigned char specifically because gcc before 9.3 seems to have a bug where it warns about bitfields not being big enough to hold the enum, even though they are.