Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed all clang -Wsigned-enum-bitfield warnings #2882

Merged
merged 1 commit into from
May 9, 2022
Merged

Fixed all clang -Wsigned-enum-bitfield warnings #2882

merged 1 commit into from
May 9, 2022

Commits on May 9, 2022

  1. Fixed all clang -Wsigned-enum-bitfield warnings 

    Made enums involved in bitfields unsigned by specifying their underlying type as unsigned char.

Due to a bug, when specifying an underlying type, gcc < 9.3 warns about bitfields not being big enough to hold the enum, even though they are. So keep the plain enum for old gcc.

An example of the bug is here:

https://godbolt.org/z/58aEv8zEq
    @seanm
    seanm committed May 9, 2022
    Configuration menu
    Copy the full SHA
    6dfb3c3 View commit details
    Browse the repository at this point in the history