Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Unicode handling when writing to an ostream on Windows #2994

Merged
merged 9 commits into from
Jul 23, 2022
Merged

Improve Unicode handling when writing to an ostream on Windows #2994

merged 9 commits into from
Jul 23, 2022

Commits on Jul 20, 2022

  1. Refactor detail::print() by splitting into two functions. 

    The part with SetConsoleW is a separate function, without fwrite().
    @dimztimz
    dimztimz committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    0cbc004 View commit details
    Browse the repository at this point in the history

  2. Make Unicode handing when writing to std::ostream more robust. 

    Calls to print(ostream&) in the special Unicode case on Windows fallback
to writing via ostream::write instead of fwrite().
    @dimztimz
    dimztimz committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    e17de67 View commit details
    Browse the repository at this point in the history

  3. Fix Unicode handling when writing to an ostream on GCC on Windows

    @dimztimz
    dimztimz committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    e6d1489 View commit details
    Browse the repository at this point in the history

  4. Add TODO note about detail::is_utf8()

    @dimztimz
    dimztimz committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    382f608 View commit details
    Browse the repository at this point in the history

  5. Fix warning -Wundef

    @dimztimz
    dimztimz committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    fe2e381 View commit details
    Browse the repository at this point in the history

  6. Fix for non-Windows OSs

    @dimztimz
    dimztimz committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    4230d74 View commit details
    Browse the repository at this point in the history

  7. Fix building as DLL on Windows

    @dimztimz
    dimztimz committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    7a94e60 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2022

  1. Refactor

    @dimztimz
    dimztimz committed Jul 23, 2022
    Configuration menu
    Copy the full SHA
    5fd371e View commit details
    Browse the repository at this point in the history

  2. Suppress warning

    @dimztimz
    dimztimz committed Jul 23, 2022
    Configuration menu
    Copy the full SHA
    72737d0 View commit details
    Browse the repository at this point in the history