Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for deprecating FindPythonInterp module. #3040

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Prepare for deprecating FindPythonInterp module. #3040

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d5ec0f
Prepare for deprecating FindPythonInterp module.
hwhsu1231 Aug 17, 2022
23ce95b
Add the proper punctuation in comments.
hwhsu1231 Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion doc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,14 @@ if (NOT DOXYGEN)
return ()
endif ()

find_package(PythonInterp QUIET REQUIRED)
# Find the python interpreter, set the PYTHON_EXECUTABLE variable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Please use proper punctuation in comments for consistency with the rest of the library.

if (CMAKE_VERSION VERSION_LESS 3.12)
# This logic is deprecated in CMake after 3.12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

find_package(PythonInterp QUIET REQUIRED)
else ()
find_package(Python QUIET REQUIRED)
set(PYTHON_EXECUTABLE ${Python_EXECUTABLE})
endif ()

add_custom_target(doc
COMMAND ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/build.py
Expand Down