Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation with FMT_ENFORCE_COMPILE_STRING and FMT_WERROR #3091

Merged
merged 1 commit into from
Sep 11, 2022
Merged

Fix compilation with FMT_ENFORCE_COMPILE_STRING and FMT_WERROR #3091

merged 1 commit into from
Sep 11, 2022

Conversation

asmaloney
Copy link
Contributor

@asmaloney asmaloney commented Sep 10, 2022

With Apple clang version 13.1.6 (clang-1316.0.21.2.5), turning on FMT_ENFORCE_COMPILE_STRING and FMT_WERROR fails to compile fmt itself.

This PR adds FMT_STRING around several strings in os.cc to fix it.

It also clang-formatted another line (172) which I left in this PR.

@vitaut vitaut merged commit 8ae5616 into fmtlib:master Sep 11, 2022
@vitaut
Copy link
Contributor

vitaut commented Sep 11, 2022

Thank you

@asmaloney asmaloney deleted the fix-compile-with-FMT_ENFORCE_COMPILE_STRING branch September 11, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants